Feat support remark 14 - Githubissues

webpack-contrib / remark-loader

Load markdown through remark with image resolving and some react-specific features.

MIT License

18 stars 11 forks source link

Feat support remark 14 #49

Closed alexander-akait closed 3 years ago

alexander-akait commented 3 years ago

This PR contains a:

[ ] bugfix
[x] new feature
[ ] code refactor
[x] test update
[ ] typo fix
[x] metadata update

Motivation / Use-Case

allow to use remark v14

Breaking Changes

Additional Info

jest still run babel on test files, need investigate

alexander-akait commented 3 years ago

/cc @SimenB maybe you know what the problem is? jest just freeze and throw Segmentation fault, here we just rewrite our tests on ECMA modules, source code in CommonJS and we use import() (dynamic import) in our source code, if I remove it jest works fine, I try to debug, but no luck

SimenB commented 3 years ago

It explodes when hitting the first import() so I assume this is https://github.com/nodejs/node/issues/35889 (segfault trace matches, so seems likely). The linked v8 issue had a bunch of movement in August, so 🤞 something comes out of it

alexander-akait commented 3 years ago

Okay, let's start investigate, because it is big blocker for updating deps for us

SimenB commented 3 years ago

It's a bug in v8, not much we can do in userland unfortunately

alexander-akait commented 3 years ago

Apparently we will have to be left without auto tests and do manual testing, as if we are returning to the stone age, we just can't update our deps and we really need new versions, I'm surprised that the problem takes so long to solve, that is very bad, thanks for link