search

webpack-contrib / sass-loader

Compiles Sass to CSS
MIT License
3.9k stars 428 forks source link

Add support for node-sass v8 to release v10 branch #1101

Closed pitgrap closed 1 year ago

pitgrap commented 1 year ago

We're still relying on webpack4 and stuck to sass-loader v10. But we want to use node-sass v8 and node 18.

So please integrate #1100 into v10. Thank you.

alexander-akait commented 1 year ago

Feel free to send a PR

pitgrap commented 1 year ago

You're too fast. ;) I was just finishing my fork and branch...

alexander-akait commented 1 year ago

@pitgrap Yeah, I got the same request from other originizations and people, so I done it fast, released https://github.com/webpack-contrib/sass-loader/releases/tag/v10.4.0

alexander-akait commented 1 year ago

I think we can close it

pitgrap commented 1 year ago

I think you missed this part in your PR: https://github.com/webpack-contrib/sass-loader/pull/1072/files

alexander-akait commented 1 year ago

Good cathc, thank you