webpack-contrib / sass-loader

Compiles Sass to CSS
MIT License
3.9k stars 428 forks source link

docs: improve the grammar of the readme #1212

Closed G-Rath closed 1 month ago

G-Rath commented 1 month ago

This PR contains a:

Motivation / Use-Case

These are a number of small grammar issues I noticed while working on #1211 which I figured I'd do a dedicated PR for - these are not Strictly Better and there are still some improvements that could be made, but they feel like a good start :)

Breaking Changes

This is not a breaking change

Additional Info

G-Rath commented 1 month ago

Looks like CI is failing due to https://github.com/sass/node-sass/issues/3420 and that it might not get fixed in favor of officially marked as unmaintained 🤔

evenstensberg commented 1 month ago

This is just a docs change, so we'll merge anyway

G-Rath commented 1 month ago

cool, thanks - I'll see if this can be worked around in the meantime by just installing a different version of Python in CI, which'll be easier now that I'm no longer a first-time contributor 🎉

evenstensberg commented 1 month ago

Awesome,good stuff 🙏

G-Rath commented 1 month ago

Have opened #1215 to fix the node-sass issue