search

webpack-contrib / sass-loader

Compiles Sass to CSS
MIT License
3.91k stars 431 forks source link

ci: use a version of Python that `node-sass` can be built on for macOS #1215

Closed G-Rath closed 4 months ago

G-Rath commented 4 months ago

This PR contains a:

Motivation / Use-Case

It seems like there isn't a precompiled version of node-sass available for macos-latest, and node-gpy then fails to build it from source due to the version not being compatible with Python 3.12.

It seems like this might be the last straw for node-sass but in the meantime we can work around this by just explicitly installing an older version of Python when running on macos-latest.

Breaking Changes

This is not a breaking change

Additional Info

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.93%. Comparing base (31789cc) to head (9cb327d). Report is 11 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1215 +/- ## ========================================== - Coverage 94.44% 93.93% -0.52% ========================================== Files 3 3 Lines 360 412 +52 Branches 132 153 +21 ========================================== + Hits 340 387 +47 - Misses 18 23 +5 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.