webpack-contrib / style-loader

Style Loader
MIT License
1.65k stars 473 forks source link

fix: noop in environment without DOM API #597

Closed alexander-akait closed 1 year ago

alexander-akait commented 1 year ago

This PR contains a:

Motivation / Use-Case

fixes https://github.com/webpack-contrib/style-loader/issues/595

Breaking Changes

No

Additional Info

Based on https://github.com/webpack-contrib/style-loader/compare/master...OlegWock:style-loader:master, but looks like we don't need to handle document here src/runtime/insertBySelector.js

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.26 :warning:

Comparison is base (382485f) 89.67% compared to head (b1a8837) 89.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #597 +/- ## ========================================== - Coverage 89.67% 89.42% -0.26% ========================================== Files 15 15 Lines 310 312 +2 Branches 155 156 +1 ========================================== + Hits 278 279 +1 - Misses 26 27 +1 Partials 6 6 ``` | [Impacted Files](https://codecov.io/gh/webpack-contrib/style-loader/pull/597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib) | Coverage Δ | | |---|---|---| | [src/runtime/isOldIE.js](https://codecov.io/gh/webpack-contrib/style-loader/pull/597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib#diff-c3JjL3J1bnRpbWUvaXNPbGRJRS5qcw==) | `0.00% <ø> (ø)` | | | [src/runtime/singletonStyleDomAPI.js](https://codecov.io/gh/webpack-contrib/style-loader/pull/597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib#diff-c3JjL3J1bnRpbWUvc2luZ2xldG9uU3R5bGVEb21BUEkuanM=) | `100.00% <ø> (ø)` | | | [src/runtime/styleDomAPI.js](https://codecov.io/gh/webpack-contrib/style-loader/pull/597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib#diff-c3JjL3J1bnRpbWUvc3R5bGVEb21BUEkuanM=) | `100.00% <ø> (ø)` | | | [src/runtime/injectStylesIntoLinkTag.js](https://codecov.io/gh/webpack-contrib/style-loader/pull/597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib#diff-c3JjL3J1bnRpbWUvaW5qZWN0U3R5bGVzSW50b0xpbmtUYWcuanM=) | `95.23% <50.00%> (-4.77%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.