support loaderContext.getLogger

webpack-contrib / thread-loader

Runs the following loaders in a worker pool

MIT License

1.12k stars 69 forks source link

support loaderContext.getLogger #216

Closed JLHwung closed 2 weeks ago

JLHwung commented 2 weeks ago

This PR contains a:

[ ] bugfix
[x] new feature
[ ] code refactor
[x] test update
[ ] typo fix
[ ] metadata update

Motivation / Use-Case

See original PR #130 for the motivation.

Breaking Changes

Additional Info

Closes #130 Fixes #185 Closes #198 Fixes https://github.com/babel/babel-loader/issues/1043

This PR is based on #130. In this PR we fixed the bug that caused the worker hanging, aligned the less-loader test case with the sass-loader one and incorporated the review comment https://github.com/webpack-contrib/thread-loader/issues/185#issuecomment-1668205463.

We also bumped babel-loader to 9.2.0, which is also affected by the issue #185.

linux-foundation-easycla[bot] commented 2 weeks ago

:white_check_mark: login: JLHwung / name: Huáng Jùnliàng (ab6fce44531f2880b9e3620a6d729caa515a7ea0, c231bd6a0b39a75a2247fe98155457ffd1058f87, ab9745d0b9dedab6a136e18a765e42727042c972, 8d396672af60dc16cccf77918073eea4ecf55741, 91829b56b41c0e1fa0181cb077d6539aacd1cbef)
:x: The email address for the commit (eb488702ca12ee11fb792bd177250293e78518b6, 34a6d4f82beb748825bd86610833d3c11d228dfb) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 19.00%. Comparing base (1bed580) to head (8d39667). Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
src/worker.js	0.00%	44 Missing and 1 partial :warning:
src/WorkerPool.js	0.00%	13 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #216 +/- ## ========================================== - Coverage 21.23% 19.00% -2.23% ========================================== Files 8 8 Lines 504 563 +59 Branches 108 111 +3 ========================================== Hits 107 107 - Misses 348 405 +57 - Partials 49 51 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexander-akait commented 2 weeks ago

Thank you