search

webpack-contrib / webpack-bundle-analyzer

Webpack plugin and CLI utility that represents bundle content as convenient interactive zoomable treemap
MIT License
12.58k stars 488 forks source link

Replace Travis with GitHub actions as CI #402

Closed valscion closed 3 years ago

valscion commented 3 years ago

Resolves https://github.com/webpack-contrib/webpack-bundle-analyzer/issues/400

valscion commented 3 years ago

I disabled the continuous-integration/travis-ci branch protection for now so that this PR is not blocked on advancing. If @th0r you feel like this is good to go, I can add branch protections for the GitHub actions if necessary.

th0r commented 3 years ago

I wonder is it possible to add Node.js prefix to version numbers as now it's a bit not obvious what do these numbers mean?

image

valscion commented 3 years ago

I don't know — I can check if that's possible when I have the time ☺️

valscion commented 3 years ago

It now looks like so:

Replace_Travis_with_GitHub_actions_as_CI_by_valscion_·_Pull_Request__402_·_webpack-contrib_webpack-bundle-analyzer

It seems quite simple to change the name to whatever we want as can be seen by fdb5a0e08b102ca1e1519d2995a35a3b84c4758b — feel free to make a direct code suggestion to this PR if you have a better wording in mind ☺️

valscion commented 3 years ago

I can add branch protections for the GitHub actions if necessary.

Do we need the branch protections? I'm not sure if they're necessary — a red CI should be enough for us to avoid merging pull requests.

The CLA-check of course stays as a required status check.

th0r commented 3 years ago

Do we need the branch protections?

I don't even know what is that =)

valscion commented 3 years ago

Ah, it's this one:

feat__Render_Selected_Module_Size_Total_by_vwb_·_Pull_Request__346_·_webpack-contrib_webpack-bundle-analyzer

So one can't merge a pull request (unless they're an admin and admin overrule is allowed) if a required status check is not successful.

We could configure some or all of the GitHub Actions status checks to be required to be successful to allow merging via https://github.com/webpack-contrib/webpack-bundle-analyzer/settings/branches, from here:

Branch_protection_rule
th0r commented 3 years ago

Ah, ok, thanks for the explanation. I don't think we need it.

valscion commented 3 years ago

Yeah I think the same, let's keep it as it is now :+1: