webpack-contrib / webpack-bundle-analyzer

Webpack plugin and CLI utility that represents bundle content as convenient interactive zoomable treemap
MIT License
12.56k stars 483 forks source link

No such label 'done hook' for WebpackLogger.timeEnd() #499

Open NexxLuo opened 2 years ago

NexxLuo commented 2 years ago

webpack v5.70.0 webpack-bundle-analyzer v4.5.0 new BundleAnalyzerPlugin()

QQ图片20220322151534

ArTiSTiX commented 1 year ago

I also have this issue when using webpack compiler in js, but not in CLI. If the compilation fails (compiled with some errors), we have this Fatal error instead of a normal compilation failure.

valscion commented 1 year ago

Are you able to create a reproduction repository showing this error happening?

ArTiSTiX commented 1 year ago

In fact i was able to find the exact case why this is happening.

In the Webpack run callback, if something throws it will trigger this error.

Ex:

const webpack = require('webpack');
const config = require('./config');
const compiler = webpack(config);

compiler.run((err, stats) => {
  throw new Error('something');
});

If the WebpackBundleAnalyzer is configured, it should trigger this error.

valscion commented 1 year ago

Adding a test that asserts the error thrown during compiler run would be a nice addition! Bonus points if the issue can be fixed, too

amareshsm commented 1 year ago

@valscion The error message seems to be from Webpack logger. Can you pls brief what kind fix is expected here?.

valscion commented 1 year ago

I don't really know what is the expected outcome to be honest 😅. What's the output if this same error is triggered but webpack-bundle-analyzer is not in the plugins list? Does webpack output the error in a nicer way that time?