search

webpack-contrib / webpack-bundle-analyzer

Webpack plugin and CLI utility that represents bundle content as convenient interactive zoomable treemap
MIT License
12.56k stars 483 forks source link

Reduce the usage of lodash #505

Closed SukkaW closed 1 year ago

SukkaW commented 2 years ago

Why do we need lodash if we can utilize features provided by the ECMAScript itself :)

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

valscion commented 1 year ago

Looks like some tests are breaking. Have you tried if running tests locally pass for you?

SukkaW commented 1 year ago

Looks like some tests are breaking. Have you tried if running tests locally pass for you?

Yeah, I have been looking into this. However, it only shows timeout (instead of test mismatch) on my side.

Update: @valscion I have fixed all failed test cases found on my machine.

valscion commented 1 year ago

Looks like there are still some test failures only found in this PR and also lint errors.

SukkaW commented 1 year ago

Looks like there are still some test failures only found in this PR and also lint errors.

Fixed the viewer.js test in f162c20 (#505) and fix lint errors from npm run lint in ead9a9b (#505).

SukkaW commented 1 year ago

Thanks, looks good to me! The diff is small enough that it seems like it shouldn't cause any regressions.

This doesn't look like it needs to be urgently released so I'll give it some time until there are other things that warrant a new release ☺️

And I am planning more PRs (that I want to be included in the next release) as well.