fix: handleValueChange.cancel is not a function

[life2015]

The error "this.handleValueChange.cancel is not a function" often occurs when I use webpack-bundle-analyzer, leading to a paralysis of page interaction.

Therefore, I have made some defensive fixes in the code here. After the fixes, the generated static pages now perform normally.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: life2015 / name: RetroX (94faa92b2a17942f44d12a7d017dabb2b2fe852f)
• :white_check_mark: login: valscion / name: Vesa Laakso (1443bf0f3ae5f1331d3fd175d8cdb2676747eede)

[valscion]

Hi! I'm having trouble understanding what the underlying cause is and thus I'm not yet willing to merge this PR as-is.

Is the this.handleValueChange still something that exists in your problem scenario or is that the thing which is somehow broken? What is it's value when that error about cancel not being a function comes to play?

[life2015]

Hi! I'm having trouble understanding what the underlying cause is and thus I'm not yet willing to merge this PR as-is.

Is the this.handleValueChange still something that exists in your problem scenario or is that the thing which is somehow broken? What is it's value when that error about cancel not being a function comes to play?

I set a breakpoint here, and then I find cancel function is undefined,

View the implementation of the corresponding obfuscated function,

I find out it is the source code of package debounce, it's source code :

There is no cancel function in debounce,maybe remove cancel() or replace this debounce package is also a good idea.

I don't know what the history of this part of the code is, so I just made a defensive fix.

[life2015]

This new debounce package is completely different from the old on lodash.debounce, I thought of two ways to solve the problem:

• revert lodash.debounce change
• change code to adapt new deboucne dependency

[life2015]

Hi! I'm having trouble understanding what the underlying cause is and thus I'm not yet willing to merge this PR as-is.

Is the this.handleValueChange still something that exists in your problem scenario or is that the thing which is somehow broken? What is it's value when that error about cancel not being a function comes to play?

Just change my code and force pushed, revert to lodash.debounce is a better idea.

[valscion]

Hey @SukkaW seems like the lodash package removals in

• https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/612

likely caused this bug.

It looks like to me that the proper fix would be to use the .clear() method instead of .cancel() — it seems to serve the same behavior as before.

[SukkaW]

Hey @SukkaW seems like the lodash package removals in

• Replace all lodash.* packages #612

likely caused this bug.

It looks like to me that the proper fix would be to use the .clear() method instead of .cancel() — it seems to serve the same behavior as before.

Oops. But since the debounce package does provide the clear, IMHO we can just switch to that and stick with debounce. @life2015 What do you think?

[valscion]

Yeah let's use the clear() function coming from the debounce package.

Can you also add a changelog entry?

[jodaka]

And while this isn't merged and released, I guess the only option for the rest of us would be to downgrade to 4.9.1, as this error makes it pretty much impossible to use report page

[valscion]

Yeah I can retag 4.9.1 as the @latest in npm so 4.10.0 isn't installed automatically for people.

EDIT: Did just that now. I'll make sure to update the latest tag in npm to a fixed version once that's out.

[life2015]

Hey @SukkaW seems like the lodash package removals in

• Replace all lodash.* packages #612

likely caused this bug. It looks like to me that the proper fix would be to use the .clear() method instead of .cancel() — it seems to serve the same behavior as before.

Oops. But since the debounce package does provide the clear, IMHO we can just switch to that and stick with debounce. @life2015 What do you think?

OK, I will use debounce package, and change cancel() to clear()

[life2015]

Just changed my code and force pushed, and added CHANGELOG. @valscion

[valscion]

The changelog entry is in the wrong place but I'll move that and merge. Thanks!

[valscion]

Released as v4.10.1 and tagged as latest in npm. Thanks for the PR, @life2015! ☺️