ci: refactor setup - Githubissues

webpack-contrib / webpack-defaults

Defaults to be shared across webpack projects

MIT License

108 stars 28 forks source link

ci: refactor setup #134

Closed alexander-akait closed 6 years ago

alexander-akait commented 6 years ago

use npm audit (it is require latest npm)
remove publish
use npm@latest where it is possible
use npm ci where it is possible (it is very fast)
fix some typos

Issues

Fixes #123

michael-ciniawsky commented 6 years ago

Seriously you can't just merge PR without sign-off at your own will, in the other issue you are talking about trust and here you are showing that having distrust might be more appropiated... In it's current form and in it's particular scope, linting commits via the CI won't simply work out, if failing the CI in approximately 80%-90% of all cases isn't the desired effect. There is not even a personal preference at play here...

alexander-akait commented 6 years ago

@michael-ciniawsky We are now working through issues (if you think what we should drop this please create issue and we continue discussion). I talked with other developers about the fact that we have constant arguments, I was given advice to work through issues. Drop commit validation is out of scope this PR, it is separate discussion. This PR just use npm audit and update npm to latest version where it is possible.