search

webpack-contrib / webpack-hot-client

webpack HMR Client
MIT License
121 stars 45 forks source link

Webpack 5: Update ParserHelpers to JavascriptParserHelpers #111

Open mvattuone opened 4 years ago

mvattuone commented 4 years ago

Feature Proposal

Maybe this is a "bug", but given I'm using a pre-RC version of webpack 5, I didn't want to make it seem like something is wrong.

Is there a plan to update 'webpack/lib/ParserHelpers' to 'webpack/lib/javascript/JavascriptParserHelpers' to make this package compatible with Webpack 5?

Here, I have it forked, and I'm happy to make a PR against the package, but I didn't want to necessarily rush things if that was intended for the next major version.

https://github.com/mvattuone/webpack-hot-client/commit/eb1465e278b854ba17cf83796a4f0ff1d24a57cd

Feature Use Case

Again, this might not be in scope, but I am still using webpack-serve which uses this package. I do not directly include it.

Perhaps I should instead use webpack-dev-server, but I wasn't clear on whether this package is used elsewhere and might need to updated regardless.

droganov commented 4 years ago

Same issue when using koa-webpack with Webpack 5

internal/modules/cjs/loader.js:626 throw err; ^

Error: Cannot find module 'webpack/lib/ParserHelpers'
Require stack:
- /www/maintined/rkta-starter/node_modules/webpack-hot-client/lib/compiler.js
- /www/maintined/rkta-starter/node_modules/webpack-hot-client/lib/index.js
- /www/maintined/rkta-starter/node_modules/koa-webpack/lib/client.js
- /www/maintined/rkta-starter/node_modules/koa-webpack/lib/index.js
neenhouse commented 4 years ago

This issue should be addressed to better support webpack 5 release (ETA ~ 1 month): https://github.com/webpack/webpack/issues/11406 otherwise webpack process critically fails

@mvattuone might be a good time to open your fork? https://github.com/webpack-contrib/webpack-hot-client/compare/master...mvattuone:master

mvattuone commented 4 years ago

@neenhouse I made a PR. I am not using this anymore and moved to webpack-dev-server, but I hope that someone looks into this further or at least admits that they aren't planning on supporting this package moving forward.