Closed msuntharesan closed 6 years ago
@vanthiyathevan first off, thank you for sending this through! its important to get things started somewhere. i'm going to go through and leave a few comments on the files / code submitted.
a few things i won't mention in the diff - we'll be following the airbnb javascript styleguide and eslint will be modified accordingly. in the meantime, it would be useful to conform to style conventions (consistent quotes, trailing newlines) as much as possible.
@jnwng - just ooc any notable mention(s) why airbnb linting/styling be the standard?
@Cryptolemming my guess is because AirBnB is one of the biggest react users (they have a styleguide for it) and we'll be using react a lot. I also think it's fine that people make choices at this stage so that we can get started as quickly as possible (obviously if a lot ppl caution of using something we can halt for a bit and think about it). These are just my thoughts though.
yeah agreed was just wondering - decisions are a good thing certainly.
learned that AirBnB is one of the biggest React users - thanks.
Is it possible to write the webpack config file in ES6 (with import
)? For raw webpack you can rename them webpack.config.babel.js
, but I'm not sure if this works with karma.
@jnwng the link to the styleguide is little bit confusing. Seems that http://airbnb.io/javascript/ is outdated, it doesn't contain anything about ES6 or React. But the link to the github repo does: https://github.com/airbnb/javascript
Do we want to follow the whole styleguide? Some rules sounds crazy, for instance to use always semicolons.
Do we want to follow the whole styleguide? Some rules sounds crazy, for instance to use always semicolons.
@timaschew Yes I agree. The dangling coma is another one
not to extend this into a syntax discussion there are plenty out there - but semicolons and the like still TC39 convention and supported by Crockford etc
So Plan of action for this PR
babel-plugin-react-transform
and react-transform-hmr
mocha
and chai
perhaps?@vanthiyathevan yep, those are good things to address. @timaschew thanks for pointing it out - i've updated the link (i got lazy googling for it and found the wrong page).
i dont think we need to follow the entire styleguide - the eslintrc
is made extensible for us to customize to what makes sense for us. they do however provide sane defaults for a majority of rules that most of us don't care about and just want to be consistent about, so i figure its a good starting point and the customization can come as needed.
Not intending to bring a syntax discussion, but my personal preferences are in favor of the entire airbnb styleguide. Especially dangling commas)) Oh, they are so useful and make merging so much easier... But I am up to anything the majority agrees too)
is anyone still working on this?
This is the initial commit of what I think are base setup for the dev test
dev
and some npm scripts