search

webpack / docs

[OLD] documentation for webpack
http://webpack.github.io/docs/
1.46k stars 127 forks source link

Update docs for NoErrorsPlugin deprecation and rename to NoEmitOnErrorsPlugin #96

Open zachlysobey opened 7 years ago

zachlysobey commented 7 years ago

The NoErrorsPlugin was deprecated in webpack PR#3570 and renamed to NoEmitOnErrorsPlugin

The docs here should probably be updated to reflect that.

BrainCrumbz commented 7 years ago

Does this still apply, now that Doc github repo moved? There seems to be no reference to none of the two in https://webpack.js.org/configuration/plugins/, nor in https://github.com/webpack/webpack.js.org/tree/master/content/plugins

zachlysobey commented 7 years ago

@BrainCrumbz I'm not really clear on where any docs have moved, or what the plan is moving forward,... but the docs I linked to still exist, and are still incomplete/misleading. If these are not the current docs, then I would guess that they should be removed, and replaced with a redirect or a link to the current documentation.

BrainCrumbz commented 7 years ago

Did you check this project home? The big prints says that they moved to https://github.com/webpack/webpack.js.org, that changes here should be done on local wiki, but then again it says to submit issues/PRs at the new repo.

So I guess a good move could be to either apply the change directly to wiki plugin list or move this issue to the new repo.

Just sayin'...

tiendq commented 7 years ago

I also used NoErrorsPlugin in an old project, just check plugins page and still don't see NoEmitOnErrorsPlugin there 👎

jwineman commented 6 years ago

I see noEmitOnErrorsPlugin here: https://webpack.js.org/plugins/no-emit-on-errors-plugin/

mernstackman commented 5 years ago

I see it on VSCode is already deprecated too and there is suggestion to use config.optimization.noEmitOnErrors

devinrhode2 commented 5 years ago

So I tried optimization.noEmitOnErrors, but optimization is not a valid configuration key for webpack THREE - so I renamed the plugin from:

    plugins: [
        new webpack.NoErrorsPlugin(),

to:

    plugins: [
        new webpack.NoEmitOnErrorsPlugin(),

The deprecation warning is gone, so I guess handling this for webpack3 is as easy as just renaming the plugin.