search

webpack / enhanced-resolve

Offers an async require.resolve function. It's highly configurable.
MIT License
916 stars 186 forks source link

feat: migrate to jest #379

Closed snitin315 closed 1 year ago

snitin315 commented 1 year ago

TODO:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -1.74 :warning:

Comparison is base (4dc1a2f) 94.64% compared to head (beed6bb) 92.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #379 +/- ## ========================================== - Coverage 94.64% 92.90% -1.74% ========================================== Files 40 43 +3 Lines 1624 2029 +405 Branches 0 598 +598 ========================================== + Hits 1537 1885 +348 - Misses 87 116 +29 - Partials 0 28 +28 ``` [see 42 files with indirect coverage changes](https://app.codecov.io/gh/webpack/enhanced-resolve/pull/379/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alexander-akait commented 1 year ago

Looks very good, did you look why coverage is now only 81%? I think we have a lot of tests so our coverage should be more...

snitin315 commented 1 year ago

@alexander-akait Yes, I'm migrating tests one by one. Once all the tests move to jest, coverage will be more.

alexander-akait commented 1 year ago

@snitin315 Ping me when it will be ready, thanks

snitin315 commented 1 year ago

@alexander-akait I have migrated all the tests. I think this is ready.