Open colinaaa opened 3 months ago
Yea, sonds good, do you want to send a PR, also is it possible to enable it by default, i.e. pnpm
has ability to detect that it is pnpm
, so we will enable this option by default in webpack?
Sure! I'm glad to send a PR. But actually, I'm not 100% sure about the correctness. Since it will make the compilation unstable(depends on the order of the requests).
@colinaaa I think we have the same issue in webpack, need to search
https://github.com/webpack-contrib/css-loader/issues/1507, I think related
What problem does this feature solve?
pnpm creates hard links from the global store to the project's node_modules folders.
For example, imagine you have the following directory structure:
packages/a
andpackages/b
have the same version oflodash
as a dependency. But they are different symlink that points to different files.Since two
lodash/lodash.js
points to different files, bothrspack
(oroxc
internally) andwebpack
(orenhanced-resolve
internally) treat the two files as unrelated. So at build time, two copies oflodash
code will be packaged in the output bundle, even if their content is the same.However, it can be found that in the file system, the two
lodash.js
point exactly to the same inode node. Which means they are the same file in physical storage.To solve the problem, we created an
enhanced-resolve
plugin to cache the request:And it works as expected in
webpack
, the duplicated modules have been eliminated.So I wonder if this could be added to
enhanced-resolve
(just like thesymlinks
options).Related issue: https://github.com/web-infra-dev/rspack/issues/5912