search

webpack / tapable

Just a little module for plugins.
MIT License
3.74k stars 395 forks source link

add es6 eslint config #101

Closed weenta closed 5 years ago

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 5 years ago

Codecov Report

Merging #101 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files          13       13           
  Lines         473      473           
  Branches       63       63           
=======================================
  Hits          448      448           
  Misses         22       22           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30efca9...80c133d. Read the comment docs.

weenta commented 5 years ago

it may not good to leave the eslint error msg such asThe keyword 'const' is reserved The keyword 'class' is reserved out there when people open the project, since we already have eslint config file, I think it may be helpful to give a quick and low risk update

mengjian-github commented 5 years ago

image

the same problem. @evilebottnawi Do you consider adopting this pr?