fix: set withOptions return type to include correct properties - Githubissues

webpack / tapable

Just a little module for plugins.

MIT License

3.71k stars 393 forks source link

fix: set withOptions return type to include correct properties #157

Closed iguessitsokay closed 3 years ago

iguessitsokay commented 3 years ago

Current behavior:

withOptions return type

does contain callAsync, which doesn't exist
doesn't contain tapAsync or tapPromise, which does exist

Expected behavior:

withOptions return type

should be limited to return value in source
should include properties depends on the current child instance

related withOptions source code: https://github.com/webpack/tapable/blob/413fa785018406464963c29d172e06d2df42f22e/lib/Hook.js#L105

sokra commented 3 years ago

Thanks