search

webpack / webpack-dev-server

Serves a webpack app. Updates the browser on changes. Documentation https://webpack.js.org/configuration/dev-server/.
MIT License
7.76k stars 1.43k forks source link

fix(deps): Replace `rimraf` with `rm`, move `rimraf` to a dev dep #5162

Closed askoufis closed 3 months ago

askoufis commented 3 months ago

For Bugs and Features; did you add new tests?

No fixes or features

Motivation / Use-Case

Now that this package's minimum supported node version is high enough, and given the relatively simple use case that rimraf is used for at runtime, IMO it's worth just using node's rm instead (via graceful-fs).

There is one more rimraf usage inside a test, but I figured that could stay. Happy to remove that too, though rimraf is still used as a CLI so it has to stay at least as a dev dep.

Breaking Changes

None

Additional Info

None

alexander-akait commented 3 months ago

Great job :+1:

askoufis commented 3 months ago

Should I rename the commit and force push so commitlint will pass?

alexander-akait commented 3 months ago

Ignore it, I will rename when will merge

alexander-akait commented 3 months ago

Looks like github actions is down - https://www.githubstatus.com/, I will rerun it when it will work