feat: add visual progress indicators

webpack / webpack-dev-server

Serves a webpack app. Updates the browser on changes. Documentation https://webpack.js.org/configuration/dev-server/.

MIT License

7.77k stars 1.43k forks source link

feat: add visual progress indicators #5186

Closed issacgerges closed 1 month ago

issacgerges commented 1 month ago

[ ] This is a bugfix
[x] This is a feature
[ ] This is a code refactor
[ ] This is a test update
[ ] This is a docs update
[ ] This is a metadata update

For Bugs and Features; did you add new tests?

No, could use guidance if they are needed

Motivation / Use-Case

Adds built-in visual progress indicators to webpack-dev-server

Breaking Changes

No breaking changes

Additional Info

minimal circular

linux-foundation-easycla[bot] commented 1 month ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: issacgerges / name: Issac Gerges (0c855ac877bad0bc53c3b105741df8b5564d5968, e66ffa05ad5ec04935b557fe73f18756b98f5b96)
:white_check_mark: login: alexander-akait / name: Alexander Akait (87808516b276bd311639fc491bde076a6bf16d3e)

alexander-akait commented 1 month ago

Thank you for you PR, can you fix lint?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.19%. Comparing base (af6bd68) to head (e66ffa0). Report is 37 commits behind head on master.

:exclamation: Current head e66ffa0 differs from pull request most recent head 8780851

Please upload reports for the commit 8780851 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #5186 +/- ## =========================================== - Coverage 90.29% 56.19% -34.11% =========================================== Files 15 11 -4 Lines 1577 1413 -164 Branches 601 555 -46 =========================================== - Hits 1424 794 -630 - Misses 140 507 +367 - Partials 13 112 +99 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

issacgerges commented 1 month ago

Should be fixed. @alexander-akait the re-run of build:types seems to have stripped all comments out. let me know if theres another way to run that command that preserves them and I can do.

issacgerges commented 1 month ago

@alexander-akait will do, sorry for moving so slow on this.

As an alternative, we could just expose some explicit API (or tell folks to lean on the postMessage you're already doing with progress) and leave implementing the visual parts to people who want them. What do you think?

alexander-akait commented 1 month ago

@issacgerges Yeah, we can, but I am fine with your solution, just let's add additional check to avoid problems with old browsers

issacgerges commented 1 month ago

Updated

Added a guard
Made the options "linear" and "circular" for consistency
Combined both into a single custom element and simplified it a bit

alexander-akait commented 1 month ago

Thank you, good work :star: