search

webpack / webpack-sources

Source code handling classes for webpack
MIT License
261 stars 71 forks source link

"Cannot read property 'length' of null" in webpack@5.47.0 #121

Closed Superoryco closed 3 years ago

Superoryco commented 3 years ago

https://github.com/webpack/webpack/issues/13879#issue-954090691

alexander-akait commented 3 years ago

Remove changing version from pr

Superoryco commented 3 years ago

null check is missing for originalSourceLines in line

alexander-akait commented 3 years ago

Fixed?

codecov[bot] commented 3 years ago

Codecov Report

Merging #121 (e69b576) into main (5024ff8) will increase coverage by 0.65%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   91.88%   92.53%   +0.65%     
==========================================
  Files          21       21              
  Lines        1478     1580     +102     
  Branches      399      462      +63     
==========================================
+ Hits         1358     1462     +104     
  Misses        109      109              
+ Partials       11        9       -2
Flag Coverage Δ
integration 92.53% <100.00%> (+0.65%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/helpers/streamChunksOfCombinedSourceMap.js 87.57% <100.00%> (-1.02%) :arrow_down:
lib/helpers/streamChunksOfSourceMap.js 96.85% <0.00%> (-0.90%) :arrow_down:
lib/CachedSource.js 92.66% <0.00%> (ø)
lib/helpers/streamChunks.js 100.00% <0.00%> (ø)
lib/helpers/createMappingsSerializer.js 100.00% <0.00%> (ø)
lib/helpers/streamAndGetSourceAndMap.js 92.10% <0.00%> (ø)
lib/SourceMapSource.js 99.18% <0.00%> (+0.01%) :arrow_up:
lib/ConcatSource.js 92.57% <0.00%> (+0.21%) :arrow_up:
lib/PrefixSource.js 82.00% <0.00%> (+0.36%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5024ff8...e69b576. Read the comment docs.