search

webpack / webpack-sources

Source code handling classes for webpack
MIT License
262 stars 71 forks source link

Avoid regex for lines #143

Closed doniyor2109 closed 2 years ago

doniyor2109 commented 2 years ago

This PR fixes some cases of this issue https://github.com/webpack/webpack-sources/issues/131

The original issue still existed for our repo. Here is failed actions

The fix was to avoid regex for other parts of the code. Here is patch worked for us https://github.com/superdispatch/web-ui/commit/7df2e1f53fe46ed1d400e6fe8cf7bd4523e94c6b

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers are authorized under a signed CLA.

alexander-akait commented 2 years ago

Thanks

codecov[bot] commented 2 years ago

Codecov Report

Merging #143 (90d5500) into main (56018ca) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   93.82%   93.80%   -0.02%     
==========================================
  Files          23       23              
  Lines        1651     1647       -4     
  Branches      480      480              
==========================================
- Hits         1549     1545       -4     
  Misses         95       95              
  Partials        7        7
Flag Coverage Δ
integration 93.80% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ReplaceSource.js 90.58% <100.00%> (-0.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56018ca...90d5500. Read the comment docs.

sokra commented 2 years ago

Thanks