search

webpack / webpack-sources

Source code handling classes for webpack
MIT License
262 stars 71 forks source link

Split code by js identifiers #45

Closed aakula-edmunds closed 3 years ago

aakula-edmunds commented 6 years ago

A fix to resolve issue 'Webpack is producing invalid sourcemaps' https://github.com/webpack/webpack/issues/8302

My changes help to do valid mapping of names (identifiers) and generate a sourcemap that pass 'sourcemap-validator' successfully. (webpack-sourcemap-testing repo can be found in the issue above)

However, if I run unit tests in this repo with my changes I get 10 failing tests mostly in PrefixSource and ReplaceSource.

Could you please help to understand what I could have missed?

@sokra @kenhoff

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

sokra commented 3 years ago

This is too expensive.

The test suite now includes tests that verify that valid source maps are generated