search

webplan-pro / currency-list

package for mutli locale currency list
8 stars 4 forks source link

Can you fix this currency symbol? #1

Closed xXAvoraXx closed 2 years ago

xXAvoraXx commented 2 years ago

Can you change Turkish Lira symbol "TL" to "₺" ?

tuturis commented 2 years ago

Can you change Turkish Lira symbol "TL" to "₺" ?

Hi, yes I will look into it:)

xXAvoraXx commented 2 years ago

Can you change Turkish Lira symbol "TL" to "₺" ?

Hi, yes I will look into it:)

Thanks 👍 :)

tuturis commented 2 years ago

I'm going to change only the "symol_native" values, are you fine with that?

On Mon, Mar 28, 2022 at 3:12 PM xXAvoraXx @.***> wrote:

Can you change Turkish Lira symbol "TL" to "₺" ?

Hi, yes I will look into it:)

Thanks 👍 :)

— Reply to this email directly, view it on GitHub https://github.com/webplan-pro/currency-list/issues/1#issuecomment-1080572760, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3OSUOFUJCHQRK4OGMEMMTVCGOY7ANCNFSM5RY6RUXA . You are receiving this because you commented.Message ID: @.***>

xXAvoraXx commented 2 years ago

I'm going to change only the "symol_native" values, are you fine with that? … On Mon, Mar 28, 2022 at 3:12 PM xXAvoraXx @.> wrote: Can you change Turkish Lira symbol "TL" to "₺" ? Hi, yes I will look into it:) Thanks 👍 :) — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3OSUOFUJCHQRK4OGMEMMTVCGOY7ANCNFSM5RY6RUXA . You are receiving this because you commented.Message ID: @.>

I think it should be in both, ₺ is a valid symbol in international.

symbol: ₺ symbol_native: ₺

tuturis commented 2 years ago

I'm going to change only the "symolnative" values, are you fine with that? … On Mon, Mar 28, 2022 at 3:12 PM xXAvoraXx @.> wrote: Can you change Turkish Lira symbol "TL" to "₺" ? Hi, yes I will look into it:) Thanks 👍 :) — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3OSUOFUJCHQRK4OGMEMMTVCGOY7ANCNFSM5RY6RUXA . You are receiving this because you commented.Message ID: _@_._>

I think it should be in both, ₺ is a valid symbol in international.

symbol: ₺ symbol_native: ₺

I think I will leave it as a native symbol for now. But I agree it's a problem in itself - how locales interpret the 'native symbol" because. An educated guess is that it again depends on the locale.

tuturis commented 2 years ago

Patched the package to 1.0.7