search

webplatformz / react-training-slides-v2

https://webplatformz.github.io/react-training-slides-v2/
MIT License
5 stars 1 forks source link

Improvements in First Components #73

Closed felixmokross closed 10 months ago

felixmokross commented 11 months ago
  1. vitest config: It was confusing for the participants that the vite config was changed to import defineConfig from vitest. I checked on their website, and for existing vite configs they recommend to just add a reference to the types, but keep importing defineConfig from vite (second code sample). @csalv22 we should adapt the exercise accordingly (didn't want to do it myself due to the step branch setup)
  2. Removed TDD as 'good practice' – debatable, not React-related
  3. Removed the test refactoring slide: It's a debatable practice, wouldn't do it myself this way. Either way, it doesn't add to the learning here.
  4. Merged the exercises into one exercise at the end of the chapter

Addresses #72 and some tasks of #68

netlify[bot] commented 11 months ago

Deploy Preview for heartfelt-clafoutis-b8a8a3 ready!

Name Link
Latest commit e427d5672bcc7dcf68769b8dcada061162c5ca6e
Latest deploy log https://app.netlify.com/sites/heartfelt-clafoutis-b8a8a3/deploys/655f69ba4b783700084e605a
Deploy Preview https://deploy-preview-73--heartfelt-clafoutis-b8a8a3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

felixmokross commented 11 months ago

Added this point to the PR:

  1. Merged the exercises into one exercise at the end of the chapter
csalv22 commented 10 months ago

Sample implementation is updated, thus the PR is fine and will be merged by me ;)