webpro-nl / knip

✂️ Find unused files, dependencies and exports in your JavaScript and TypeScript projects. Knip it before you ship it!
https://knip.dev
ISC License
7.06k stars 177 forks source link

Skip indexing into a gh action if its not an array #827

Closed butlerx closed 3 weeks ago

butlerx commented 3 weeks ago

Skip checking a github action step if its not an array as its possibly a templated string. In gh actions a valid config is ${{ toJSON(steps) }} which breaks the plugins parsing. if we see a string we should just skip those steps

pkg-pr-new[bot] commented 3 weeks ago

Open in Stackblitz

bun add https://pkg.pr.new/knip@827

commit: 23bf22c

webpro commented 3 weeks ago

Thanks @butlerx! Should be out shortly.

webpro commented 3 weeks ago

:rocket: This pull request is included in v5.36.1. See Release 5.36.1 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.