Closed MindTooth closed 1 year ago
Thanks @MindTooth, sounds like a good idea. Personally I don't know much about this and I don't use it myself either.
Looking at the GitHub Action output it gives an error: "Username and password required"
We're using repository: webpronl/reveal-md
(note the extra nl
), might that be related?
My bad. Just pushed a fix.
Hmm. 🤔 Not sure why this does not work. I’ve been successfully using the action myself. I did notice that the username needed to be lower case. Also made sure to use your variable name. Maybe I’ve typed it wrong.
Noticed that org.opencontainers.image.licenses
is empty.
Created a test pull request in my own fork, only changed the image name, and was able to login just fine. https://github.com/MindTooth/reveal-md/pull/1/checks
Care to check if I'm using the correct secret names and if the token is not expired or anything?
Can you verify that it looks something similar as mine fork?
Looking at this comment from the action itself https://github.com/docker/login-action/issues/236#issuecomment-1179770617.
Yes it that was setup properly I think, but I created a new access token anyway. Trying on master branch now.
Something else I need to do for moving this forward? 😄
Apple Silicon:
$ docker run --rm -it webpronl/reveal-md:master -V
Unable to find image 'webpronl/reveal-md:master' locally
3ab7ed8f550a: Download complete
1a48d4233f62: Download complete
b2e6e996e4a8: Download complete
937e20b5a2d7: Download complete
762c2470eea4: Download complete
fefc7d195eee: Download complete
4f4fb700ef54: Exists
06fc22ed341f: Download complete
c41833b44d91: Download complete
984930a9222d: Download complete
ab7e1f12004b: Download complete
a97409de93e9: Download complete
5.4.1
Let's see what happens now ðŸ¤
It works. 🥳 However, it only pushed to master
. I don't recall, but that's the correct behavior? latest
is last stable release?
I reworked the action to support multi-arch builds. Notices that it did not have any and was not able to run it on my Apple Silicon. Some code is borrowed from the various actions.
Notice
provenance: false
which continue to build the image using older mediatypes. There is still runtimes used that does not support the new types.Let me know if you need more from me. I'm usually next to a computer for an easy fix. 😄
I've published some images here to test the changes.