Internal links not working in some cases with vertical slides

webpro / reveal-md

reveal.js on steroids! Get beautiful reveal.js presentations from any Markdown file

MIT License

3.71k stars 416 forks source link

Internal links not working in some cases with vertical slides #453

Closed nuke-web3 closed 8 months ago

nuke-web3 commented 1 year ago

Here is a minimal reproducible example: https://github.com/NukeManDan/reveal-md/tree/broken-internal-links (and the delta https://github.com/NukeManDan/reveal-md/commit/75c4954bdc80ad408f203816033dfe35138e5696 )

node bin/reveal-md.js demo/ and navigating to http://localhost:1948/sub/deep/d.md#/ will show the behavior:

working ones are as expected
broken ones will navigate to the title/first slide

Expected behavior is id specified will work with horizontal and vertical slides. Not sure if this is a reveal-md or reveal.js bug (I suspect the former).

webpro commented 10 months ago

Can you narrow it down to what links exactly fail and why/when?

nuke-web3 commented 10 months ago

https://github.com/webpro/reveal-md/compare/main...NukeManDan:reveal-md:broken-internal-links shows the minimal diff here, where the link I hope are self describing :crossed_fingers:

when I click a [something](#location) link in the slides, I expect to navigate to the slide in question, in the example here it doesn't navigate to the slide that includes that header.

webpro commented 10 months ago

Are you saying that the links like #/1 or #/2/1 are not working?

webpro commented 8 months ago

Closing due to inactivity. Not sure I understood, perhaps the answer is "custom internal links are not supported".