search

webpro / reveal-md

reveal.js on steroids! Get beautiful reveal.js presentations from any Markdown file
MIT License
3.71k stars 416 forks source link

Fix the inclusion of a custom theme when using `--static` #458

Closed MartenBE closed 10 months ago

MartenBE commented 12 months ago

This fixes https://github.com/webpro/reveal-md/issues/439 for me.

MartenBE commented 11 months ago

I have tested this in the mean time with both a local css file, and a remote css file using a https://... link. Both seem to work fine.

nuke-web3 commented 11 months ago

@MartenBE thanks for this! Sadly you branch doesn't work for me in https://github.com/Polkadot-Blockchain-Academy/pba-book - the css is missing from the bun serve-slides command, I am sure I have something mangled vs what is "right" for the reveal-md settings and mapping them to files I need in the build and/or serve.

MartenBE commented 11 months ago

@NukeManDan I've checked your PR and dived deeper in the code, I've combined it to this. This solution has been tested with a css file and an css link. It seems to work for both static (listing and chapter) and watch. Could you recheck if this works?

MartenBE commented 11 months ago

Nice, I fixed a unit test regression and formatted the code to spec. If it runs ok for you, it is ready to go.

MartenBE commented 11 months ago

@NukeManDan let me know if you have reviewed the code, I'll ask for the maintainer to merge it then.

webpro commented 11 months ago

Thanks, planning to review and go through some issues and pull requests this weekend.

MartenBE commented 11 months ago

@webpro Is there any update on this? I would like to deploy using github pages to show my colleagues about reveal-md, but this prevents me from doing that unfortunately: the result with the "missing" custom css file isn't appealing.

webpro commented 10 months ago

Thanks @MartenBE and @NukeManDan! This is included in v5.5.2

MartenBE commented 10 months ago

@webpro Thank you very much for the update! For my colleagues I created following test case: https://hogenttin.github.io/hogent-revealmd/ . It shows a how to use intro, basic examples and even advanced examples such as iframes, fragments and multicolumn layout. It also demonstrates autodeployment using Github Actions and support for linting and dead link checking.