search

webpro / reveal-md

reveal.js on steroids! Get beautiful reveal.js presentations from any Markdown file
MIT License
3.71k stars 416 forks source link

Why are images that are not in the same folder not recognized? #488

Open ooker777 opened 2 months ago

ooker777 commented 2 months ago

It seems that only images in the same folder are recognized. If it's in the parent then it won't work. Is this a conscious choice or you don't have the time to work on it?

webpro commented 2 months ago

It was a conscious choice to keep things simple. Assets and images should be in the same or sub folders.

ooker777 commented 2 months ago

I get that it is indeed simple. But in my project I'd like to keep the image folder and note folder separated, as there are images shared by various notes. Those notes can be in their own subfolders. So having to duplicate the images will make noise when I need to manage the notes only, and hard to keep track the version. In that case do you think it's better to allow the relative path to access parent directories?

webpro commented 2 months ago

The challenge was that reveal-md is basically a simple http server that serves static assets and also allows to export it all as a stand-alone HTML website.

Feel free to take a stab at it though, I'm happy to review PRs.

ooker777 commented 2 months ago

I'm still not sure what simplicity this achieves. Is it for the users or for the devs? I'm not working on it yet, but I imagine it should be no problem for the server to get files from parents?

webpro commented 2 months ago

In the end it's just putting in the work to achieve something. I once had this idea to build something that allows to write Markdown and spin up a Reveal.js deck. It does what I need. Other can use it too. Others can contribute too. This is where we are today :)

ooker777 commented 2 months ago

Yeah I understand that. I just want to know why you make that decision, that's all. Not intend to ask you to work on it :)