fix: get image path from HTML <img src=""> tag

webpro / reveal-md

reveal.js on steroids! Get beautiful reveal.js presentations from any Markdown file

MIT License

3.74k stars 416 forks source link

fix: get image path from HTML <img src=""> tag #493

Open ooker777 opened 3 months ago

ooker777 commented 3 months ago

fix: preprocessor argument doesn't work with Windows paths #490
fix: get image path from HTML tag

pkg-pr-new[bot] commented 3 months ago

Run & review this pull request in StackBlitz Codeflow.

commit: bde37e1

reveal-md

``` npm i https://pkg.pr.new/webpro/reveal-md@493 ```

templates

- [default](https://pkg.pr.new/template/4612f1bb-f594-4fe0-b71e-979032f62126)

ooker777 commented 3 months ago

@webpro sorry for the confusion. The correct commit for this PR is only 571889f. Subsequent commits should be for different PRs. Each of them is for a different feature. I didn't know that when I did the push. Now it's my understanding that I have to create different branches if I want to open different PRs. Do you still need me to do that, or can you just review all of them at one?

MartenBE commented 2 months ago

It's probably best to create a PR for each for history (in case a bug has to be tracked down)

webpro commented 2 months ago

Do you still need me to do that, or can you just review all of them at one?

Yes, please create separate PRs for separate fixes/features.