search

webpro / reveal-md

reveal.js on steroids! Get beautiful reveal.js presentations from any Markdown file
MIT License
3.71k stars 416 forks source link

Copy img in html tag #496

Closed MartenBE closed 1 week ago

MartenBE commented 2 weeks ago

I use <img ... /> tags so I can rescale them using width, height or style="width: ...; height: ..." attributes. Although the live server shows everything fine, the static website missed all the images declared in this way. Upon further inspection, the regex to detect images only detects markdown images and not HTML <img> tags. This PR should enable both.

pkg-pr-new[bot] commented 2 weeks ago

commit: 1534803

npm i https://pkg.pr.new/webpro/reveal-md@496

Open in Stackblitz

MartenBE commented 2 weeks ago

Damn, I created the PR first and then saw that a PR for this already exists: https://github.com/webpro/reveal-md/pull/493 :p I think this PR is the really really lightweight version (+/- 5 changed lines) of that one

webpro commented 2 weeks ago

Thanks @MartenBE! Except that it also contains the dependency updates. We can just merge that one first once its ready, or fix up this one separately. Up to you, happy to merge either way.

MartenBE commented 1 week ago

You can merge the dependancies now, then this PR. I've merged it together.

webpro commented 1 week ago

Cherry picked in 358f16281b29e2cb19d46f38c8b86d027ab9bde4

webpro commented 1 week ago

Thanks for the fix @MartenBE! Much appreciated.