webprofusion / certify

Professional ACME Client for Windows. Certificate Management UI, powered by Let's Encrypt and compatible with all ACME v2 CAs. Download from certifytheweb.com
https://certifytheweb.com
Other
1.48k stars 256 forks source link

Propagation timer not being preserved when using Constellix API (posh-acme) script #637

Closed stephen-dunne closed 1 year ago

stephen-dunne commented 1 year ago

v 6.0.5

The "Propagation Delay Seconds" timer value isn't being saved when changed away from the default 90s value. A change will only stick if you change the script to another provider, change it back to constellix and then lower the propagation delay timer before saving it. You're also not prompted to save the entry when only changing the timer.

I suspect you're not checking whether this particular field has changed..

webprofusion-chrisc commented 1 year ago

Thanks Stephen, yes it looks like there is a bug some field changed don't trigger the "IsChanged" property of our model and in some cases changes can get skipped, fix in the next update.