webraptor / react-native-deck-swiper

tinder like react-native deck swiper
ISC License
126 stars 81 forks source link

Add support for react-native 0.62 #1

Closed jacquesdev closed 3 years ago

jacquesdev commented 3 years ago

Is it possible for someone to please add the required updates to make it work with rn0.62?

(@webraptor, I know you are already working on it)🥳

webraptor commented 3 years ago

Indeed

Also contacted npm so that in the near future we'll be able to make new releases on the same package.

gitschwifty commented 3 years ago

What issues are you having on 0.62? I'm using RN 0.63 and not seeing any breaking issues, just warnings from Animated, and I believe my team member who implemented it originally was still on 0.62 when he did so. I could ask him to see if he had any issues or if he figured out a fix.

jacquesdev commented 3 years ago

@gitschwifty - it was based on this issue, https://github.com/alexbrillant/react-native-deck-swiper/issues/306. I did not actually try, just assumed it's an issue.

gitschwifty commented 3 years ago

I could throw together a repro to test it out but I'd like to hear from the people who reported it, the error they got could've easily been from something else & based on the trace I'm not sure it came from this package in the first place.

Harin329 commented 3 years ago

I was on 0.62 a month ago and it was fine, updated to 0.63 and it's still good, only thing is the Animated warning as mentioned

gitschwifty commented 3 years ago

I'd mark this as needs more info and/or close this issue unless someone reports a current problem, not sure the people commenting in 306 will respond & I don't think it's an issue with this package.

jacquesdev commented 3 years ago

Agreed