search

webrecorder / browsertrix-browser-base

6 stars 3 forks source link

Upgrade from `ubuntu:jammy` to `ubuntu:noble` #19

Open benoit74 opened 1 month ago

benoit74 commented 1 month ago

Now that Ubuntu noble 24.04LTS has been released, I think it is time to migrate browsertrix images to it

benoit74 commented 1 month ago

I gave it a try without success so far.

Without other modification in the Dockerfile, installation fails with a weird error:

E: Package 'libasound2' has no installation candidate

Weird because libasound2 is supposed to still be present in Ubuntu noble, even if it is now a virtual package: https://packages.ubuntu.com/cs/noble/libasound2

I tried to install liboss4-salsa-asound2 instead of libasound2 (since libasound2 is a virtual package provided by liboss4-salsa-asound2 ...) but then brave installation fails

#11 [brave 3/6] RUN echo "installing Brave from linux/amd64"; dpkg -i brave.deb; apt-get -f install -y; rm -f brave.deb
#11 0.047 installing Brave from linux/amd64
#11 0.067 Selecting previously unselected package brave-browser.
#11 0.079 (Reading database ... 47780 files and directories currently installed.)
#11 0.080 Preparing to unpack brave.deb ...
#11 0.085 Unpacking brave-browser (1.66.115) ...
#11 5.774 dpkg: dependency problems prevent configuration of brave-browser:
#11 5.774  brave-browser depends on libasound2 (>= 1.0.17); however:
#11 5.774   Package libasound2 is not installed.
#11 5.774   Version of libasound2 on system, provided by liboss4-salsa-asound2:amd64, is <none>.
#11 5.774  brave-browser depends on brave-keyring; however:
#11 5.774   Package brave-keyring is not installed.

Others seems to have the same issue: https://github.com/microsoft/playwright/issues/30368#issuecomment-2097554177

benoit74 commented 1 month ago

Edit: this is not a weird error but I was just mislead by information at https://packages.ubuntu.com/cs/noble/libasound2, there are two candidate packages for libasound2:

Package libasound2 is a virtual package provided by:
  liboss4-salsa-asound2 4.2-build2020-1ubuntu3
  libasound2t64 1.2.11-1build2 (= 1.2.11-1build2)
You should explicitly select one to install.

When installing libasound2t64, brave installation succeeds. Just like the whole image build.

I will submit a PR.