Open SuaYoo opened 5 months ago
Anything I can help with here @emma-sg @Shrinks99 ?
Reviewed with voice over... Not sure I got everything but this is a start! Screenshot analysis is not going to be very helpful... I'm sure text analysis could be improved in a few ways that would help everyone regardless of ability such as doing what GitHub does an only surfacing the actual different sections!
The resource comparison table is by far the most usable for anyone who is completely unsighted. It works quite well! Good labels for all the rows and columns and gives context to each value!
executionTimeFormatter
elsewhere.Cancel
button is highlighted initially which means it's the first content read aloud. Users have to know that there is more text "above" and request it with keyboard navigation controls. Should be title of the dialog.btrix-pagination
should have an aria-role
attribute that we define with a label
attribute when creating the component?Heading level 3, pagename
, should probably be Current page: Pagename
[DATE] collapsed menu button group
, should probably start with Analysis run date:...
Current URL:
Capture date:
Match %: [percentage]
<ins>
and <del>
to represent text that has is present VS missing.Have started a branch for this: https://github.com/webrecorder/browsertrix/commits/frontend-qa-a11y-fixes
Probably won't get to all of these points, some are harder to fix than others (dates and dropdowns are a hard one I think?) Will have a go and try to pick off all the low hanging fruit.
Alright, I think I'm done with the issues I can address confidently... The others deserve a little more thought as to how they'll fit in with our other components? Would prefer these be addressed by @SuaYoo or @emma-sg. :)
I've checked off the ones I've gotten to in the list above. The ones without checkmarks are maybe worth addressing with some larger strategy app-wide? The ones still unchecked should be addressed and are the more pressing issues IMO. Lets merge #1863 and do the above separately to keep things manageable? Nothing in there should be super related to anything else on the list.
Of all of these, the review tab not surfacing information for the current item only is probably the biggest issue??
:focus-visible
styling @emma-sg