Closed SuaYoo closed 2 months ago
Resolves https://github.com/webrecorder/browsertrix/issues/1983
Updates browser title when visiting the following pages:
Follows a similar approach to React </a>.</p> <h3>Manual testing</h3> <ol> <li>Log in</li> <li>Navigate around org pages. Verify browser title bar updates to reflect the top-level org navigation.</li> </ol> <h3>Screenshots</h3> <table> <thead> <tr> <th>Page</th> <th>Image/video</th> </tr> </thead> <tbody> <tr> <td>Brower Profiles</td> <td><img width="829" alt="Screenshot 2024-08-28 at 1 32 27 PM" src="https://github.com/user-attachments/assets/30903668-c3f9-4c95-86a8-178296baabf0"></td> </tr> </tbody> </table> <h3>Follow-ups</h3> <p>Once file refactors in <a rel="noreferrer nofollow" target="_blank" href="https://github.com/webrecorder/browsertrix/pull/2053">https://github.com/webrecorder/browsertrix/pull/2053</a> and <a rel="noreferrer nofollow" target="_blank" href="https://github.com/webrecorder/browsertrix/pull/2020">https://github.com/webrecorder/browsertrix/pull/2020</a> are merged we can add page titles for detail views as well.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
Resolves https://github.com/webrecorder/browsertrix/issues/1983
Changes
Updates browser title when visiting the following pages:
Follows a similar approach to React</a>.</p>
<h3>Manual testing</h3>
<ol>
<li>Log in</li>
<li>Navigate around org pages. Verify browser title bar updates to reflect the top-level org navigation.</li>
</ol>
<h3>Screenshots</h3>
<table>
<thead>
<tr>
<th>Page</th>
<th>Image/video</th>
</tr>
</thead>
<tbody>
<tr>
<td>Brower Profiles</td>
<td><img width="829" alt="Screenshot 2024-08-28 at 1 32 27 PM" src="https://github.com/user-attachments/assets/30903668-c3f9-4c95-86a8-178296baabf0"></td>
</tr>
</tbody>
</table>
<h3>Follow-ups</h3>
<p>Once file refactors in <a rel="noreferrer nofollow" target="_blank" href="https://github.com/webrecorder/browsertrix/pull/2053">https://github.com/webrecorder/browsertrix/pull/2053</a> and <a rel="noreferrer nofollow" target="_blank" href="https://github.com/webrecorder/browsertrix/pull/2020">https://github.com/webrecorder/browsertrix/pull/2020</a> are merged we can add page titles for detail views as well.</p> </div>
</div>
<div class="page-bar-simple">
</div>
<div class="footer">
<ul class="body">
<li>© <script>
document.write(new Date().getFullYear())
</script> Githubissues.</li>
<li>Githubissues is a development platform for aggregating issues.</li>
</ul>
</div>
<script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script>
<script src="/githubissues/assets/js.js"></script>
<script src="/githubissues/assets/markdown.js"></script>
<script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script>
<script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script>
<script>
hljs.highlightAll();
</script>
</body>
</html>