search

webrecorder / browsertrix

Browsertrix is the hosted, high-fidelity, browser-based crawling service from Webrecorder designed to make web archiving easier and more accessible for all!
https://webrecorder.net/browsertrix
GNU Affero General Public License v3.0
201 stars 35 forks source link

fix: Watch tab crawl state consistency #2060

Closed SuaYoo closed 2 months ago

SuaYoo commented 2 months ago

Fixes https://github.com/webrecorder/browsertrix/issues/2059

Changes

Manual testing

Verify with repro steps in https://github.com/webrecorder/browsertrix/issues/2059

The following should be true:

ikreymer commented 2 months ago

Browser Window editing is enabled when a crawl is in any active state that is not stopping

When a crawl is starting, it was enabled in the menu but the button was disabled, though menu item didn't do anything. I think it should be enabled for starting as well in this case.. I think we can have it be enabled for any state in RUNNING_AND_WAITING_STATES though in some of these it won't have an effect until later, but should be possible to change I think. Users might want to scale down if crawl is waiting for capacity (though it'll still start even if desired scale can't be attained)

SuaYoo commented 2 months ago

When a crawl is starting, it was enabled in the menu but the button was disabled, though menu item didn't do anything. I think it should be enabled for starting as well in this case..

What states are included in isCrawlRunning? That's what the button currently checks. I also see that it's enabled for starting, could you provide more repro steps?

Screenshot 2024-09-10 at 12 30 15 PM
ikreymer commented 2 months ago

What states are included in isCrawlRunning? That's what the button currently checks. I also see that it's enabled for starting, could you provide more repro steps?

Yep, seems to be working now and the other issue also resolved, maybe was running an older version. Looks good!