webrecorder / browsertrix

Browsertrix is the hosted, high-fidelity, browser-based crawling service from Webrecorder designed to make web archiving easier and more accessible for all!
https://webrecorder.net/browsertrix
GNU Affero General Public License v3.0
201 stars 35 forks source link

feat: Localization workflow improvements #2069

Closed SuaYoo closed 2 months ago

SuaYoo commented 2 months ago

Partially addresses https://github.com/webrecorder/browsertrix/issues/1416

Changes

Manual testing

  1. Regression test UI for number and plural formatting.
  2. Verify staged changes to frontend/src will run localization string extraction on commit
SuaYoo commented 2 months ago

I worry a little that the precommit is getting too large (even without extracting strings it's a few seconds)

I'd be in favor of removing the lint check from pre-commit and just having it in CI, now that the webpack build shows linting errors?

emma-sg commented 2 months ago

Yeah, would be very down for that!