webrecorder / browsertrix

Browsertrix is the hosted, high-fidelity, browser-based crawling service from Webrecorder designed to make web archiving easier and more accessible for all!
https://webrecorder.net/browsertrix
GNU Affero General Public License v3.0
201 stars 35 forks source link

Ensure email comparisons are case-insensitive, emails stored as lowercase #2084

Closed ikreymer closed 2 months ago

ikreymer commented 2 months ago
ikreymer commented 2 months ago

@tw4l Since we're using EmailStr more strictly now, we can't support url-encoded emails with @ as %40. If we want to support that, should add it to our custom EmailStr to url-decode emails, but I'm not sure if that's needed?

tw4l commented 2 months ago

@tw4l Since we're using EmailStr more strictly now, we can't support url-encoded emails with @ as %40. If we want to support that, should add it to our custom EmailStr to url-decode emails, but I'm not sure if that's needed?

That's fine! Not sure I even meant to encode that part of the email addresses in the tests, that might have been a mistake.