Add `site_url` - Githubissues

webrecorder / browsertrix

Browsertrix is the hosted, high-fidelity, browser-based crawling service from Webrecorder designed to make web archiving easier and more accessible for all!

https://webrecorder.net/browsertrix

GNU Affero General Public License v3.0

201 stars 35 forks source link

Add `site_url` #2130

Open Shrinks99 opened 2 weeks ago

Shrinks99 commented 2 weeks ago

Changes

Tells MkDocs where the site will be published at allowing it to generate a sitemap

ikreymer commented 2 weeks ago

This should probably be parametrized, since local deployment will have the docs hosted locally at: http://localhost:30870/docs/ or a local domain...

Shrinks99 commented 2 weeks ago

I don't think it does much that would affect the local builds? The value is ignored for the locally built sitemap with mkdocs serve

Details here: https://www.mkdocs.org/user-guide/configuration/#site_url

...That said you're also not wrong! What would be the best way of making this variable? Could add a line that appends it to the docs deploy script?