feat: Localize dates, bytes, and numbers - Githubissues

webrecorder / browsertrix

Browsertrix is the hosted, high-fidelity, browser-based crawling service from Webrecorder designed to make web archiving easier and more accessible for all!

https://webrecorder.net/browsertrix

GNU Affero General Public License v3.0

201 stars 35 forks source link

feat: Localize dates, bytes, and numbers #2146

Closed SuaYoo closed 2 days ago

SuaYoo commented 1 week ago

Resolves https://github.com/webrecorder/browsertrix/issues/2143

Changes

Defaults to user's browser language preference when displaying dates, bytes, and numbers (with caveats.) This fixes an issue where numbers were always formatted in English.
Shows user's browser language preferences in language dropdown
Fixes timezone not displayed in archived item detail start and finish times
Standardizes number formatting
Sets timezone that unit tests run in

Manual testing

Tested with Firefox and Chrome

Set language preference in browser of choice
Log in
Verify dates, bytes, and numbers are displayed correctly in chosen language
Go to Account Settings
Change language preference to a language that displays numbers differently
Go back to org dashboard. Verify date/byte/numbers are displayed correctly

Screenshots

Page	Image/video
Account Settings
Collections	(Browser language set to Korean, no app language set)
Archived Item Detail

SuaYoo commented 2 days ago

Using the pagination on the crawl workflows list seems to result in an error. None of the other pages experience this problem. This does not happen in main. I made sure to run yarn to build new packages.

Nice catch, fixed!