search

webrecorder / browsertrix

Browsertrix is the hosted, high-fidelity, browser-based crawling service from Webrecorder designed to make web archiving easier and more accessible for all!
https://webrecorder.net/browsertrix
GNU Affero General Public License v3.0
201 stars 35 forks source link

[Bug]: No error on "Page URL" without protocol #2165

Open SuaYoo opened 2 days ago

SuaYoo commented 2 days ago

Browsertrix Version

v1.12.1-e0a93fc

What did you expect to happen? What happened instead?

The frontend doesn't show an error when a URL is entered without http/https. The backend does return an error, but it isn't visible.

Reproduction instructions

  1. Log in as crawler
  2. Go to new Crawl Workflow
  3. Choose Single Page scope
  4. Enter www.example.com
  5. Click "Review & Save"
  6. Click "Save Workflow". The workflow isn't saved, and the server error isn't visible

Screenshots / Video

No response

Environment

No response

Additional details

Originally reported by @dcgomes. There are a few issues here:

  1. The backend server message isn't visible until the page is all the way scrolled down
  2. The frontend treats www.domain.com as a valid URL while the backend does not. The frontend correctly shows an error for a string without www..

We can probably get away automatically appending https if it's omited.