webrecorder / browsertrix

Browsertrix is the hosted, high-fidelity, browser-based crawling service from Webrecorder designed to make web archiving easier and more accessible for all!
https://webrecorder.net/browsertrix
GNU Affero General Public License v3.0
205 stars 36 forks source link

Investigate switching to novnc JS library for browser profiles #533

Open SuaYoo opened 1 year ago

SuaYoo commented 1 year ago

Currently, we are just using the vnc_lite.html as an iframe: https://github.com/webrecorder/browsertrix-crawler/blob/main/html/vnc_lite.html so can only set the variables that it loads there, via readQueryVariable These are set on the backend in: https://github.com/webrecorder/browsertrix-cloud/blob/main/backend/btrixcloud/profiles.py#L162 But perhaps time has come to use our own wrapper instead of that iframe, to make things more customizable?

Originally posted by @ikreymer in https://github.com/webrecorder/browsertrix-cloud/issues/530#issuecomment-1409700475

Criteria

Methods

Outcome

This investigation will determine whether we can migrate to a completely client JS-based browser profile editor with minimal work (within a sprint) and whether this will allow us to access to more features like resizing.

SuaYoo commented 2 months ago

@ikreymer do we want to proceed with this issue, or unschedule it for now?