webrecorder / pywb

Core Python Web Archiving Toolkit for replay and recording of web archives
https://pypi.python.org/pypi/pywb
GNU General Public License v3.0
1.37k stars 214 forks source link

String not set as translatable in template #867

Closed Quirinus closed 10 months ago

Quirinus commented 11 months ago

Describe the bug

In the error.html template, on line 6, "Pywb Error" inside the <h2> tag isn't set to be translatable. Link to the line.

The translation string for it already exists because it's set to be translatable just a few lines above (when setting the page title).

Steps to reproduce the bug

Clone new repository, set up translations as per the documentation, change the "Pywb Error" string in translation file, open the Pywb site, change translation language to the one you translated, open an error page by using a collection link that doesn't exist (has to include the translation language code in the URL), the title "Pywb Error" remains the same (not translated).

Expected behavior

The heading "Pywb Error" is translated when the error page opens. Just like the page title.

Screenshots

image Notice how the other text is translated (including the page title), but the "Pywb Error" heading isn't. The URL in the screenshot is: http://localhost:8080/hr/dsfgd/

Environment

Quirinus commented 11 months ago

Fixed in the pull request: #868