DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version

[benoit74]

Since Python 3.12, we have the following DeprecationWarning:

warcio/recordbuilder.py:156: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    return datetime_to_iso_date(datetime.datetime.utcnow(), use_micros=use_micros)

Pretty easy to fix in 3.12, but maybe not that easy in reality since you probably wanna maintain 2.7+ and 3.4+ support. I suggest to not use what the DeprecationWarning suggests but datetime.datetime.now(tzinfo = datetime.tzinfo.UTC) which should be OK (to be checked).

[benoit74]

I tried to work on this feature by first adding support for Python 3.12 but I fail to get the tests running with it.

First problem is in test_capture_http_proxy.py:

• werkzeug dependency must be pinned to 2.0.3 for working with httpbin==0.5.0
• setup(cls) should be replaced by setup_class(cls)
• requests complains that proxies set are not a valid URL (we should probably add the "http://" prefix manually)
• but even after that the HTTPS tests are still failing
• upgrading to latest httpbin / werkzeug version does not help

I don't know how to fix this situation

[wumpus]

Tessa @tw4l is working on getting rid of the httpbin version dependency in PR 153 https://github.com/webrecorder/warcio/pull/153 -- and she's setting up Github Actions so we'll have CI again. Once that's done you'll easily be able to finish this one.

[benoit74]

Oh great, thank you! I'm glad I stopped before investing too much time in this ^^

[tw4l]

I'm struggling with the same HTTPS proxy issue as you document above, but hopefully will work it out soon!

[benoit74]

Good luck! (I have my own share of struggling, I know what this is ^^)

[tw4l]

Turns out pinning urllib3 to an older version for now resolves it! PR to switch to GitHub Actions CI is now open :) https://github.com/webrecorder/warcio/pull/164