webrecorder / webrecorder-player

Webrecorder Player for Desktop (OSX/Windows/Linux). (Built with Electron + Webrecorder)
Apache License 2.0
432 stars 38 forks source link

Player doesn't support links which go to images? #60

Closed vitorio closed 5 years ago

vitorio commented 6 years ago

Hello, I'm archiving a social media site, and some of the links on the site go directly to image files (e.g. binary data served as image/jpeg).

While Webrecorder.io captures the JPEG file, and will display it online, Webrecorder Player doesn't seem to. Clicking the link doesn't do anything. The JPEG file is in the WARC, I can manually visit it in the online Webrecorder.io site. But I can't paste the captured JPEG URL into Webrecorder Player, it doesn't appear in the bookmark list (since it's not an HTML page), and there appears to be no way to view it.

Is this the expected behavior? That non-HTML pages are not bookmarks and also not able to be viewed when clicked on as links?

ikreymer commented 5 years ago

This may be partially fixed as there was an issue where links that opened in a new tab did not work at all in the player. They should now open in the same tab. In case the JPEG links were opening in a new tab, this may work now in 1.6.0

We are working on a more general way to access non-bookmark resources in the WARC and to add them as bookmarks in Webrecorder itself. This will eventually be available in webrecorder.io

ikreymer commented 5 years ago

Additionally, you can also enter any url directly into the location bar and it will be loaded in the player. (There was a bug in 1.6.0 but should work in 1.6.1)

Closing this for now as this should address most of the issues.