search

webrecorder / wombat

Wombat.js client-side rewriting library
GNU Affero General Public License v3.0
82 stars 30 forks source link

Image lazy loading #23

Closed edsu closed 2 years ago

edsu commented 4 years ago

I don't have a sense of how common they are in the wild yet, but will lazy loaded images need to be auto-fetched?

ikreymer commented 4 years ago

Yeah, or a simpler option might be to just remove/rewrite the loading=lazy attribute if present.

ikreymer commented 2 years ago

Auto-capture of lazy loaded images is now handled via browsertrix behaviors (webrecorder/browsertrix-behaviors#23), moving auto-fetch implementations to there, as its something that only want to do when crawling. Probably doesn't make sense to make part of core wombat, as don't want to do this always for replay.