2.x-feature -> 2.x-develop | Fixed: settings api routes

[we-alam-a001]

Task #369 - 2023-06-10 VaahCMS > Test All API Time invested: 02:00 format | Billable: 02:00 | Non-Billable: 00:00

Client's comment or requirement

Proof of your testing, video, or image link?

video link :- (https://img-v1.dev.getdemo.dev/screenshot/Postman_VOm91kp3Ub.mp4)

Self Review Checklist

Naming Conventions

For a detailed information click here

• [ ] Are your Controller names meaningful, singular and have Controller suffix?
• [ ] Are your Model names singular and named after the table they are modelling?
• [ ] Are your Table names snake_case and plural?
• [ ] Are your Table Column names snake_case without model name?
• [ ] Are your Seeder names descriptive about which table they are seeding?
• [ ] Are your method/function names short, descriptive and camelCased?
• [x] Are your variable names short, descriptive and snake_cased?

Constants and Configs

For a detailed information click here

• [x] API keys, Secret Keys, URL's etc., are stored as env variables.
• [x] I am accessing env variables via config.
• [x] I have used config and language files, constants instead of text in the code .
• [x] I have not hardcoded any value.

Fat methods and CRUD

For a detailed information click here

• [x] All requests are being validated
• [ ] I am not using raw SQL queries. I am using Eloquent queries.
• [ ] DB related logic are in Eloquent models or in Repository/Helper classes.
• [x] I have not included business logic in Controllers. They are in Repository/Helper classes.
• [ ] My methods adhere to the Single Responsibility Principle.
• [ ] My code doesn't contain extensive if-else nesting. I am checking negative conditions first.
• [x] I have removed all unwanted commented code.
• [ ] I have done my tech debt analysis and any unavoidable code leading to tech debt is marked with @todo .

Other practices

• [ ] All my migrations have down method that reverses operations performed by up method.
• [ ] Any new column added/altered in table has been also updated in the fillable property of its model.
• [x] For seeders that are not populating sample data, it is not truncating table before seeding again.
• [ ] For seeders that are not populating sample data, the data is being populated from a separate external file.
• [x] There are no business logic or queries in routes.
• [x] I have not put queries in Blade templates.
• [x] I have not put JS and CSS in Blade templates and have not put any HTML in PHP classes.
• [x] I have removed all debug code.

Nuxt coding practices

• [ ] My Vue Components names are short, describes what it's intended use is and is in PascalCase
• [ ] All the components exclusive to the page are in the page's components folder
• [ ] I have preferred using Composition API.
• [ ] I have preferred using Githubissues.
• Githubissues is a development platform for aggregating issues.