hide VNet implementation behind cargo feature

webrtc-rs / util

Utilities for WebRTC.rs stack

https://webrtc.rs

Apache License 2.0

6 stars 15 forks source link

hide VNet implementation behind cargo feature #6

Closed chertov closed 3 years ago

chertov commented 3 years ago

I have a problem with mDNS package on old armv5te platforms Armv5te doesn't support AtomicU64 and AtomicI64 types https://doc.rust-lang.org/std/sync/atomic/#portability this types are using in "vnet" mod.. Can we hide it behind cargo feature or change it to AtomicU32 and AtomicI32 for support this platform? mDNS package doesn't use vnet module but has this dependency

rainliu commented 3 years ago

thanks for reporting this issue. Will fix this by using cargo feature for util crate.

metaclips commented 3 years ago

@rainliu can we use this crate instead for getting network interfaces https://docs.rs/pnet/0.8.1/pnet/index.html

rainliu commented 3 years ago

@chertov, I just upgrade webrtc-util to v0.1.19 in crates.io.

You can update mDNS crate's dependent util version to v0.1.19 in order to disable vnet feature.